

1·
2 months agoThis looks like a colossally bad idea:
if (!strcmp(platform, "windows") && !isSpecificPlatform) {
debugLog("Falling back to rm -rf", 2);
debugLog(strfmt("rm -rf exited with code %d",system(strfmt("rm -rf %s", path))), 3);
}
In addition,
However, their even though their client doesn’t allow vibe coding, it is still written in Python, which itself takes ai contributions.
Per the Makefile, this project is built using GCC. GCC itself accepts AI contributions, provided that the code is “legally insignificant” (meaning less than around 15 lines of code) or is part of test cases: https://gcc.gnu.org/ai-policy.html
To add to the last comment, I’d also suggest not mixing logging and business code. That is to say that you should put the
systemcall on its own line, so that it is clear that it’s not just a logging call:if (!strcmp(platform, "windows") && !isSpecificPlatform) { debugLog("Falling back to rm -rf", 2); int result = system(strfmt("rm -rf %s", path)); debugLog(strfmt("rm -rf exited with code %d", result), 3); }It may just be a me problem, but I have a tendency to skim over the logging lines unless I’m intentionally reading code carefully, in which case the system call may get overlooked